linux-kernel - Re: [PATCH 1/5]PCI: x86 MMCONFIG: introduce PCI_USING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20071219230447.GA24219@suse.de>
Date:	Wed, 19 Dec 2007 15:04:47 -0800
From:	Greg KH <gregkh@...e.de>
To:	tcamuso@...hat.com
Cc:	linux-kernel@...r.kernel.org, linux-pci@...ey.karlin.mff.cuni.cz,
	prarit@...hat.com
Subject: Re: [PATCH 1/5]PCI: x86 MMCONFIG: introduce PCI_USING_MMCONF

On Wed, Dec 19, 2007 at 05:17:51PM -0500, tcamuso@...hat.com wrote:
> commit d1f2a573ca7083d237cfc354f42e089de9fa0f0b
> Author: Tony Camuso <tony.camuso@...com>
> Date:   Wed Dec 19 15:33:53 2007 -0500
> 
>     Introduces a flag bit to arch/x86/pci/pci.h to indicate that
>     MMCONFIG is the system-wide default PCI config access mechanisim.
>     
>     Function pci_mmcfg_init() in arch/x86/pci/mmconfig-shared.c sets
>     the bit in the pci_probe mask when MMCONFIG has been successfully
>     initialized for the platform.
>     
>     Signed-off-by: Tony Camuso tony.camuso@...com
> 
> diff --git a/arch/x86/pci/mmconfig-shared.c b/arch/x86/pci/mmconfig-shared.c
> index 4df637e..fc0f866 100644
> --- a/arch/x86/pci/mmconfig-shared.c
> +++ b/arch/x86/pci/mmconfig-shared.c
> @@ -274,7 +274,8 @@ void __init pci_mmcfg_init(int type)
>  			unreachable_devices();
>  		if (known_bridge)
>  			pci_mmcfg_insert_resources(IORESOURCE_BUSY);
> -		pci_probe = (pci_probe & ~PCI_PROBE_MASK) | PCI_PROBE_MMCONF;
> +		pci_probe = pci_probe & ~PCI_PROBE_MASK;
> +		pci_probe = pci_probe | PCI_PROBE_MMCONF | PCI_USING_MMCONF;
>  	} else {
>  		/*
>  		 * Signal not to attempt to insert mmcfg resources because
> diff --git a/arch/x86/pci/pci.h b/arch/x86/pci/pci.h
> index ac56d39..53f4051 100644
> --- a/arch/x86/pci/pci.h
> +++ b/arch/x86/pci/pci.h
> @@ -28,6 +28,7 @@
>  #define PCI_ASSIGN_ALL_BUSSES	0x4000
>  #define PCI_CAN_SKIP_ISA_ALIGN	0x8000
>  #define PCI_USE__CRS		0x10000
> +#define PCI_USING_MMCONF	0x20000
>  
>  extern unsigned int pci_probe;
>  extern unsigned long pirq_table_addr;
> @@ -39,6 +40,8 @@ enum pci_bf_sort_state {
>  	pci_dmi_bf,
>  };
>  
> +extern struct pci_ops pci_legacy_ops; 	/* direct.c */

This isn't needed in this patch at all, and might make the compiler
confused if you were to build with only this patch present :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/