linux-kernel - Re: [PATCH 1/3] ps3: vuart: fix error path locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1198029288.2716.25.camel@imap.mvista.com>
Date:	Tue, 18 Dec 2007 17:54:48 -0800
From:	Daniel Walker <dwalker@...sta.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Geoff Levand <geoffrey.levand@...sony.com>,
	matthias.kaehlcke@...il.com, linux-kernel@...r.kernel.org,
	linux@...mer.net, linuxppc-dev@...abs.org, mingo@...e.hu,
	kjwinchester@...il.com
Subject: Re: [PATCH 1/3] ps3: vuart: fix error path locking

On Tue, 2007-12-18 at 17:10 -0800, Andrew Morton wrote:

> is correct.  Although not exactly a thing of beauty.

This isn't the worst I've seen ;( .. Do you think the ending should fall
through instead of having two returns?

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/