linux-kernel - not needed patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Dec 2007 20:57:02 -0800
From:	Yinghai Lu <Yinghai.Lu@....COM>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: not needed patch

Ingo.

commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9  is not needed. 
another patch  (by you !! commit 699d934d5f958d7944d195c03c334f28cc0b3669  x86: fixup cpu_info array conversion)
already removed clearing of c->cpu_index. in identify_cpu

also it is not consisent to smpboot_32.c. (it will assign id to cpu_index right after 
 	*c = boot_cpu_data;
)

by revert commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9, we could use c->cpu_index in identify_cpu.

YH

commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9
Author: Mike Travis <travis@....com>
Date:   Wed Dec 19 23:20:19 2007 +0100

    x86: fix show cpuinfo cpu number always zero
    
    when called by setup_arch) after smp_store_cpu_info() had set it to the
    correct value.
    
    The error shows up in 'cat /proc/cpuinfo' will all cpus = 0.
    
    Signed-off-by: Mike Travis <travis@....com>
    Cc: Andi Kleen <ak@...e.de>
    Cc: Christoph Lameter <clameter@....com>
    Cc: Jack Steiner <steiner@....com>
    Cc: Suresh B Siddha <suresh.b.siddha@...el.com>
    Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
    Signed-off-by: Ingo Molnar <mingo@...e.hu>
    Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

diff --git a/arch/x86/kernel/smpboot_64.c b/arch/x86/kernel/smpboot_64.c
index 500670c..5948895 100644
--- a/arch/x86/kernel/smpboot_64.c
+++ b/arch/x86/kernel/smpboot_64.c
@@ -141,8 +141,8 @@ static void __cpuinit smp_store_cpu_info(int id)
 	struct cpuinfo_x86 *c = &cpu_data(id);
 
 	*c = boot_cpu_data;
-	c->cpu_index = id;
 	identify_cpu(c);
+	c->cpu_index = id;
 	print_cpu_info(c);
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/