linux-kernel - [PATCH -mm] kobject_add : kill unnecessary warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20071220090732.GA3274@darkstar.te-china.tietoenator.com>
Date:	Thu, 20 Dec 2007 17:07:32 +0800
From:	Dave Young <hidave.darkstar@...il.com>
To:	Greg KH <greg@...ah.com>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH -mm] kobject_add : kill unnecessary warning

Hi,
I don't know whether you or others have this change or not, if not please consider apply.

Kill the unnecessary warning in kobject_add if sysfs file EEXIST because of there's a similar one in sysfs_add_one

Signed-off-by: Dave Young <hidave.darkstar@...il.com> 

---
kobject.c |   13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)

diff -upr linux/lib/kobject.c linux.new/lib/kobject.c
--- linux/lib/kobject.c	2007-12-20 09:02:49.000000000 +0800
+++ linux.new/lib/kobject.c	2007-12-20 17:00:09.000000000 +0800
@@ -265,19 +265,10 @@ int kobject_add(struct kobject * kobj)
 
 	error = create_dir(kobj);
 	if (error) {
+		printk(KERN_ERR "kobject_add failed for %s (%d)\n",
+			       kobject_name(kobj), error);
 		/* unlink does the kobject_put() for us */
 		unlink(kobj);
-
-		/* be noisy on error issues */
-		if (error == -EEXIST)
-			printk(KERN_ERR "kobject_add failed for %s with "
-			       "-EEXIST, don't try to register things with "
-			       "the same name in the same directory.\n",
-			       kobject_name(kobj));
-		else
-			printk(KERN_ERR "kobject_add failed for %s (%d)\n",
-			       kobject_name(kobj), error);
-		dump_stack();
 	}
 
 	return error;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/