linux-kernel - Re: [PATCH] adt7470: Support per-sensor alarm files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071220105808.1d9a044b@hyperion.delvare>
Date:	Thu, 20 Dec 2007 10:58:08 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	"Darrick J. Wong" <djwong@...ibm.com>
Cc:	lm-sensors <lm-sensors@...sensors.org>,
	"Mark M. Hoffman" <mhoffman@...htlink.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] adt7470: Support per-sensor alarm files

Hi Darrick,

On Wed, 19 Dec 2007 14:11:25 -0800, Darrick J. Wong wrote:
> On Wed, Dec 19, 2007 at 03:40:12PM +0100, Jean Delvare wrote:
> > In general we keep the all-in-one alarms file for compatibility, but
> > given that this driver is fairly new and libsensors never had specific
> > support for it anyway, it's probably OK to drop it this time.
> 
> Thanks for the code review.  I've made the changes you asked for and
> here's a new patch to supersede yesterday's.
> ---
> Remove the old alarms hack and replace it with per-sensor alarm files.
> 
> Signed-off-by: Darrick J. Wong <djwong@...ibm.com>

Looks alright to me this time.

Acked-by: Jean Delvare <khali@...ux-fr.org>

BTW, did you try your driver with lm-sensors 3.0.0?

Thanks,
-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/