linux-kernel - Re: [PATCH v4 7/8] debugfs: allow access to signed values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Dec 2007 13:47:13 +0100
From:	Arnd Bergmann <ARNDB@...ibm.com>
To:	Stefano Brivio <stefano.brivio@...imi.it>
Cc:	Johannes Berg <johannes@...solutions.net>,
	Akinobu Mita <akinobu.mita@...il.com>,
	"John W. Linville" <linville@...driver.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Mattias Nissler <mattias.nissler@....de>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	hch@....de
Subject: Re: [PATCH v4 7/8] debugfs: allow access to signed values

On Thursday 20 December 2007, Stefano Brivio wrote:
> debugfs: allow access to signed values
> 
> Add debugfs_create_s{8,16,32,64}. For these to work properly, we need to remove
> a cast in libfs, change the simple_attr_open prototype and thus fix the users as
> well.
> 
> Cc: Johannes Berg <johannes@...solutions.net>
> Cc: Mattias Nissler <mattias.nissler@....de>
> To: Greg Kroah-Hartman <gregkh@...e.de>
> To: Arnd Bergmann <arndb@...ibm.com>
> To: Akinobu Mita <akinobu.mita@...il.com>
> Signed-off-by: Stefano Brivio <stefano.brivio@...imi.it>

Have you checked that spufs still builds? I would guess that you need
to do the same interface changes there.

Also, Christoph has recently posted a suggestion for how to improve
the interface to allow the 'get' operation to return an error:
http://patchwork.ozlabs.org/cbe-oss-dev/patch?id=14962

I'd suggest consolidating the two changes in order to avoid merge
conflicts.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/