linux-kernel - Re: [PATCH] Move page_assign_page_cgroup to VM_BUG_ON in free_hot_cold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071220091215.a87d2588.akpm@linux-foundation.org>
Date:	Thu, 20 Dec 2007 09:12:15 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	balbir@...ux.vnet.ibm.com
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Hugh Dickins <hugh@...itas.com>,
	Dave Hansen <haveblue@...ibm.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Move page_assign_page_cgroup to VM_BUG_ON in
 free_hot_cold_page

On Thu, 20 Dec 2007 21:54:15 +0530 Balbir Singh <balbir@...ux.vnet.ibm.com> wrote:

> >> struct page_cgroup *page_get_page_cgroup(struct page *page)
> >> {
> >> 	return (struct page_cgroup *)
> >> 		(page->page_cgroup & ~PAGE_CGROUP_LOCK);
> >> }
> >>
> >> I guess the issue is that often a "get" function has a complementary
> >> "put" function, but this isn't one of them.  Would page_page_cgroup
> >> be a better name, perhaps?  I don't know.
> > 
> > Ah, yes, I mistakenly assumed it was a reference get. In that case I
> > stand corrected and do not have any objections.
> > 
> 
> I was going to say the same thing, page_get_page_cgroup() does not hold
> any references. May be _get_ in the name is confusing.

It is a bit unconventional.  page_cgroup()?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/