linux-kernel - Re: [PATCH] Move page_assign_page_cgroup to VM_BUG_ON in free_hot_cold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <476AA8EE.1000206@linux.vnet.ibm.com>
Date:	Thu, 20 Dec 2007 23:09:58 +0530
From:	Balbir Singh <balbir@...ux.vnet.ibm.com>
To:	Hugh Dickins <hugh@...itas.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Dave Hansen <haveblue@...ibm.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Move page_assign_page_cgroup to VM_BUG_ON in free_hot_cold_page

Hugh Dickins wrote:
> On Thu, 20 Dec 2007, Andrew Morton wrote:
>> On Thu, 20 Dec 2007 21:54:15 +0530 Balbir Singh <balbir@...ux.vnet.ibm.com> wrote:
>>> I was going to say the same thing, page_get_page_cgroup() does not hold
>>> any references. May be _get_ in the name is confusing.
>> It is a bit unconventional.  page_cgroup()?
> 
> Seems ideal to me
> (though there is some argument for page_page_cgroup(), weird as it is).
> 
> Hugh

Sounds good to me as well, except that it sounds like a constructor :-)
I'll try and make the changes and submit a patch. I am in the middle of
losing control_type now (based on Hugh's comments)

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/