linux-kernel - Re: Kernel bug: bluetooth meets TTY layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Dec 2007 21:17:10 +0100
From:	Arjan van de Ven <arjan@...ux.intel.com>
To:	David Newall <david@...idnewall.com>
CC:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Marcel Holtmann <marcel@...tmann.org>,
	linux-kernel@...r.kernel.org
Subject: Re: Kernel bug: bluetooth meets TTY layer

David Newall wrote:
> Hi Arjan,
> 
> I've not been able to find this file, "drivers/bluetooth/hci_tty.c", but 
> anyway, This seems to be what happens: Hci_uart_close() flushes using 
> hci_uart_flush().  Subsequently, in hci_dev_do_close(), (one step in 
> hci_unregister_dev()), hci_uart_flush() is called again.  The comment in 
> uart_flush_buffer(), relating to the WARN_ON(), indicates you can't 
> flush after the port is closed; which sounds reasonable.  I think 
> hci_uart_close() should set hdev->flush to NULL before returning.  
> Hci_dev_do_close() does check for this.  The code path is rather 
> involved and I'm not entirely clear of all steps, but I think that's 
> what should be done.
> 
> Patch for stupidly obsolete kernel attached.

looks reasonable; unfortunately I don't know the tty code well enough to judge this patch...
Alan?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/