linux-kernel - Re: Trying to convert old modules to newer kernels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071220220547.GA5641@uranus.ravnborg.org>
Date:	Thu, 20 Dec 2007 23:05:47 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	"linux-os (Dick Johnson)" <linux-os@...logic.com>
Cc:	Lennart Sorensen <lsorense@...lub.uwaterloo.ca>,
	Linux kernel <linux-kernel@...r.kernel.org>
Subject: Re: Trying to convert old modules to newer kernels

On Thu, Dec 20, 2007 at 04:27:37PM -0500, linux-os (Dick Johnson) wrote:
> 
> On Thu, 20 Dec 2007, Sam Ravnborg wrote:
> 
> >>
> >> It never gets to the printk(). You were right about the
> >> compilation. Somebody changed the kernel to compile with
> >> parameter passing in REGISTERS! This means that EVERYTHING
> >> needs to be compiled the same way, 'C' calling conventions
> >> were not good enough!
> >
> > How did you build the module. It reads like you failed to use
> > kbuild to build your module which is why you did not pass
> > correct options to gcc - correct?
> >
> > If you did not use kbuild - why not?
> > Is there anything missing you need?
> >
> > 	Sam
> >
> 
> I need to get rid of -mregparm=3 on gcc's command line. It
> is completely incompatible with the standard calling conventions
> used in all our assembly-language files in our drivers. We make
> very high-speed number-crunching drivers that munge high-speed
> data into images. We need to do that in assembly as we have
> always done.
That I understand. So you need a CONFIG_ option to switch off
-regparm=3 and pray that the kernel assembly supports it.

And then I assume you avoided kbuild because it added -regparm=3
which is why your simple module broke.

As you are well aware there is not any testing of a kernel without
-regparm=3 these days so you should strongly consider making your
assembly module comply with -regparm=3.

And no - I dunno how much work that is and what impact it has
on your number chrunching stuff.
But it looks like the only sane long-term solution to me.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/