linux-kernel - Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m17ij97zao.fsf@ebiederm.dsl.xmission.com>
Date:	Thu, 20 Dec 2007 15:54:07 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	peerchen@...il.com, linux-kernel@...r.kernel.org,
	acurrid@...dia.com, pchen@...dia.com
Subject: Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability

Andrew Morton <akpm@...ux-foundation.org> writes:

> On Wed, 19 Dec 2007 16:41:25 -0800
> Andrew Morton <akpm@...ux-foundation.org> wrote:
>
>> It would be better to just add a stub implementation of
>> ht_enable_msi_mapping() for all the other architectures - avoid fancy cpp
>> tricks.
>
>
> And by this I really do mean going into each include/asm-*/pci.h and adding
>
>
> struct pci_dev;		(if needed)
> ...
>
> static inline void ht_enable_msi_mapping(struct pci_dev *dev)
> {
> }
>
>
> no macros, no ifdef tricks, no include tricks.  Just straight, clean, fully
> typechecked C.

Andrew thanks for the code style review.  I goofed about recommending the
ARCH_HAVE_XXXX thing.

I'm going to concentrate on the content for the moment.  I think we
are very close to a general solution to a very common problem with
MSI interrupts.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/