linux-kernel - Re: [PATCH - SH/Dreamcast] Add support for GD-Rom device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071221122619.GC11583@kernel.dk>
Date:	Fri, 21 Dec 2007 13:26:19 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Adrian McMenamin <lkmladrian@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org,
	Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [PATCH - SH/Dreamcast] Add support for GD-Rom device

On Fri, Dec 21 2007, Jens Axboe wrote:
> static void gdrom_readdisk_dma(struct work_struct *work)
> {
>         ...
> 
>         read_command = kzalloc(sizeof(struct packet_command), GFP_KERNEL);
>         if (!read_command)
>                 probably just defer the work to some time later
> 
>         spin_lock(&gdrom_lock);
>         while (!list_empty(&gdrom_deferred)) {
>                 req = list_entry(gdrom_deferred.next, struct request, queuelist);
>                 list_del_init(&req->queuelist);
>                 spin_unlock(&gdrom_lock);
> 
>                 ...
> 
>                 spin_lock(&gdrom_lock);
>         };
> 
+         spin_unlock(&gdrom_lock);
>         kfree(read_command);
> }

is missing, of course.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/