linux-kernel - Re: [PATCH 1/2] DMA buffer alignment annotations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adafxxwx9v9.fsf@cisco.com>
Date:	Fri, 21 Dec 2007 08:58:50 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	Russell King <rmk+lkml@....linux.org.uk>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-scsi@...r.kernel.org, davem@...emloft.net,
	james.bottomley@...eleye.com, ralf@...ux-mips.org
Subject: Re: [PATCH 1/2] DMA buffer alignment annotations

 > > +#define __dma_aligned	  	__attribute__((aligned(ARCH_MIN_DMA_ALIGNMENT)))
 > > +#define __dma_buffer		__dma_buffer_line(__LINE__)
 > > +#define __dma_buffer_line(line)	__dma_aligned;\
 > > +				char __dma_pad_##line[0] __dma_aligned

 > You introduce __dma_buffer_line() if ARCH_MIN_DMA_ALIGNMENT is set but
 > not if it isn't...

__dma_buffer_line() is just an internal implementation detail to take
care of string pasting properly.  Perhaps there should be a comment
warning people not to use it directly.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/