linux-kernel - Re: OOPS: 2.6.24-rc5-mm1 -- EIP is at r_show+0x2a/0x70 -- (triggered by "cat /proc/iomem" AFTER suspend-to-disk/resume)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Dec 2007 12:00:00 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Miles Lane" <miles.lane@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"Christoph Lameter" <clameter@....com>,
	"Pavel Machek" <pavel@...e.cz>,
	linux-pm@...ts.linux-foundation.org, Dave Airlie <airlied@...ux.ie>
Subject: Re: OOPS: 2.6.24-rc5-mm1 -- EIP is at r_show+0x2a/0x70 --
 (triggered by "cat /proc/iomem" AFTER suspend-to-disk/resume)

On Fri, 21 Dec 2007 11:06:49 -0500 "Miles Lane" <miles.lane@...il.com> wrote:

> > >
> > > How do I determine what comes next?
> > >
> >
> > By comparing it with the /proc/iomem from prior to suspending the machine.
> >
> 
> The offending information seems to be "90000000-90000fff : Intel Flush Page"

ah-hah.  git-agpgart.patch

> I hope this helps,

It does, thanks.

Dave, a `cat /proc/iomem' crashes after a suspend/resume cycle when it
reaches the intel_private.ifp_resource record.


intel_i915_configure() is called on each resume and it calls
intel_i9xx_setup_flush() which zeroes out the already-registered `struct
resource', causing core kernel to oops over a deref of
parent/sibling/child.

Probably this:

--- a/drivers/char/agp/intel-agp.c~a
+++ a/drivers/char/agp/intel-agp.c
@@ -883,8 +883,6 @@ static void intel_i965_g33_setup_chipset
 static void intel_i9xx_setup_flush(void)
 {
 	/* setup a resource for this object */
-	memset(&intel_private.ifp_resource, 0, sizeof(intel_private.ifp_resource));
-
 	intel_private.ifp_resource.name = "Intel Flush Page";
 	intel_private.ifp_resource.flags = IORESOURCE_MEM;
 
_


will be enough to prevent the crash, but I suspect a bit more than that
will be needed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/