linux-kernel - Re: [PATCH] [RFC] be more verbose when probing EDD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <476C6D06.2070301@zytor.com>
Date:	Fri, 21 Dec 2007 17:48:54 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Andi Kleen <andi@...stfloor.org>
CC:	devzero@....de, linux-kernel@...r.kernel.org, Matt.Domsch@...l.com
Subject: Re: [PATCH] [RFC] be more verbose when probing EDD

Andi Kleen wrote:
> "H. Peter Anvin" <hpa@...or.com> writes:
> 
>> devzero@....de wrote:
>>>         /* Query EDD information */
>>>  #if defined(CONFIG_EDD) || defined(CONFIG_EDD_MODULE)
>>> -       query_edd();
>>> +        printf("Probing EDD (query Bios for boot-device information)\n");
>>> +        printf("If boot hangs here, you may have a buggy Bios. Try edd=skipmbr or edd=off");
>>> +        query_edd();
>>> +        printf("\rOK                                                                       \n");
>>>  #endif
>> This is awfully verbose.
> 
> But useful. On the other hand we have lots of IMNSHO
> quite useless printks in early bootup that could be removed
> to make up for that
> 
> (e.g. candidates would be the 
> "CPU: After/before generic identify"
> or 
> Entering add_active_range....) 
> 
> printks and you can easily make up for the added verbosity.
> 

Those don't live in an area of memory which is hard-limited to 32K.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/