linux-kernel - Re: [PATCH] Fix RTC_AIE with CONFIG_HPET_EMULATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1198433711.31341.1228016275@webmail.messagingengine.com>
Date:	Sun, 23 Dec 2007 19:15:11 +0100
From:	"Clemens Ladisch" <clemens@...isch.de>
To:	"Bernhard Walle" <bwalle@...e.de>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Cc:	tglx@...utronix.de
Subject: Re: [PATCH] Fix RTC_AIE with CONFIG_HPET_EMULATE_RTC

Bernhard Walle wrote:
> In the current code, RTC_AIE doesn't work if the RTC relies on
> CONFIG_HPET_EMULATE_RTC because the code sets the RTC_AIE flag
> in hpet_set_rtc_irq_bit(). The interrupt handles does accidentally
> check for RTC_PIE and not RTC_AIE when comparing the time
> which was set in hpet_set_alarm_time().
> 
> This patch is against 2.6.24-rc5-mm1.
> 
> 
> Signed-off-by: Bernhard Walle <bwalle@...e.de>

Acked-by: Clemens Ladisch <clemens@...isch.de>

> ---
>  arch/x86/kernel/hpet.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/arch/x86/kernel/hpet.c
> +++ b/arch/x86/kernel/hpet.c
> @@ -657,7 +657,7 @@ irqreturn_t hpet_rtc_interrupt(int irq, 
>  		hpet_pie_count = 0;
>  	}
>  
> -	if (hpet_rtc_flags & RTC_PIE &&
> +	if (hpet_rtc_flags & RTC_AIE &&
>  	    (curr_time.tm_sec == hpet_alarm_time.tm_sec) &&
>  	    (curr_time.tm_min == hpet_alarm_time.tm_min) &&
>  	    (curr_time.tm_hour == hpet_alarm_time.tm_hour))
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/