linux-kernel - Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.9999.0712221939570.21557@woody.linux-foundation.org>
Date:	Sat, 22 Dec 2007 19:46:06 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jeff Garzik <jeff@...zik.org>
cc:	Arjan van de Ven <arjan@...radead.org>,
	linux-kernel@...r.kernel.org, gregkh@...e.de,
	linux-pci@...ey.karlin.mff.cuni.cz,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: [patch] Make MMCONFIG space (extended PCI config space) a driver
 opt-in issue

On Sat, 22 Dec 2007, Jeff Garzik wrote:
>
> I forcibly turn on mmconfig on all my machines, and monitor lkml, to make sure
> I'm aware of the extent of the problem -- and the extent of peoples'
> exaggeration of this problem.

Bullshit.

You have how many machines? Ten?

The problem is that it isn't enough that it works on common machines with 
good hardware. The problem is that we end up chasing insane bugs, wasting 
peoples valuable time and effort, on those *few* - out of *millions* - of 
machines that then surprisingly don't work.

And "surprisingly" is definitely the watch-word. That includes silently 
just not booting (because the first time anybody tries to do a PCI config 
cycle access, the machine just locks up) to some really *odd* behaviour 
(ie everything works fine *except* that reading the PCI card ID from a 
few cards returns a value of 0x0001 rather than the correct one).

The fact is, we're currently turning off MMCONFIG very aggressively, 
exactly because it has caused problems. So most people never even use 
MMCONFIG when it's enabled, because all of our sanity checks that turn it 
off again. And it still has caused odd problems.

> Regardless of whether a driver is loaded or not, you may NEED to see extended
> capabilities.  The system may NEED to see those capabilities just to parse
> them for sane operation.

And that's just not true.

I don't know why you even claim so. There is absolutely *zero* need for 
MMCONFIG for 100% of old hardware, and old hardware is exactly the 
problem. The hardware that people will run next year isn't the issue.

There may be an absolute need for MMCONFIG for future machines and future 
drivers, but there is not a single machine in existence today that really 
depends on it. You're just making things up. At worst, you lose some 
not-so-important error reporting, no more.

So don't go spreading obvious untruths,

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/