[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <476DF0A3.9070701@garzik.org>
Date: Sun, 23 Dec 2007 00:22:43 -0500
From: Jeff Garzik <jeff@...zik.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
CC: Arjan van de Ven <arjan@...radead.org>,
linux-kernel@...r.kernel.org, gregkh@...e.de,
linux-pci@...ey.karlin.mff.cuni.cz,
Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: [patch] Make MMCONFIG space (extended PCI config space) a driver
opt-in issue
Linus Torvalds wrote:
> On Sun, 23 Dec 2007, Jeff Garzik wrote:
>>> And yes, if you want the capability following to notice automatically when
>>> capabilities really do go into the 0x100+ range, that's fine. I suspect
>> Yes, we /must/ do this checking, if we don't already.
>
> Hell no. If the user asked for mmconfig to be disabled, it needs to be
> disabled, because it may well be broken and non-working. It's better to
> not see some capabilities than to lock up the machine.
I think my short response created confusion. I was only saying that we
should check for capability overruns, if we don't already[1].
I wasn't saying anything about mmconfig in that sentence, sorry.
Let's pop this sub-thread off the stack, and jump to your "Sounds like a
plan?" train of thought.
Jeff
[1] Lioc's response seems to imply my worry about overruns is unfounded.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists