linux-kernel - Re: [PATCH 3/38] arch/ia64/sn: Use time_before, time_before

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071225.002553.56248499.yoshfuji@linux-ipv6.org>
Date:	Tue, 25 Dec 2007 00:25:53 +0900 (JST)
From:	YOSHIFUJI Hideaki / 吉藤英明 
	<yoshfuji@...ux-ipv6.org>
To:	julia@...u.dk
Cc:	jes@....com, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/38] arch/ia64/sn: Use time_before, time_before_eq,
 etc.

In article <Pine.LNX.4.64.0712241518040.23999@....diku.dk> (at Mon, 24 Dec 2007 15:18:56 +0100 (CET)), Julia Lawall <julia@...u.dk> says:

> diff -r -u -p a/arch/ia64/sn/kernel/xpc_main.c b/arch/ia64/sn/kernel/xpc_main.c
> --- a/arch/ia64/sn/kernel/xpc_main.c	2007-11-12 10:35:56.000000000 +0100
> +++ b/arch/ia64/sn/kernel/xpc_main.c	2007-12-23 20:32:54.000000000 +0100
> @@ -230,7 +231,7 @@ xpc_hb_beater(unsigned long dummy)
>  {
>  	xpc_vars->heartbeat++;
>  
> -	if (jiffies >= xpc_hb_check_timeout) {
> +	if (time_before_eq(jiffies, xpc_hb_check_timeout)) {
>  		wake_up_interruptible(&xpc_act_IRQ_wq);
>  	}
>  

time_after_eq()

> @@ -270,7 +271,7 @@ xpc_hb_checker(void *ignore)
>  
>  
>  		/* checking of remote heartbeats is skewed by IRQ handling */
> -		if (jiffies >= xpc_hb_check_timeout) {
> +		if (time_before_eq(jiffies, xpc_hb_check_timeout)) {
>  			dev_dbg(xpc_part, "checking remote heartbeats\n");
>  			xpc_check_remote_hb();
>  

ditto.

> @@ -305,7 +306,7 @@ xpc_hb_checker(void *ignore)
>  		/* wait for IRQ or timeout */
>  		(void) wait_event_interruptible(xpc_act_IRQ_wq,
>  			    (last_IRQ_count < atomic_read(&xpc_act_IRQ_rcvd) ||
> -					jiffies >= xpc_hb_check_timeout ||
> +			     time_before_eq(jiffies, xpc_hb_check_timeout) ||
>  						(volatile int) xpc_exiting));
>  	}
>  

ditto.

--yoshfuji
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/