linux-kernel - Re: [RFC/PATCH 2/4] pci: Remove users of pci_enable_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071224071300.GC3758@colo.lackof.org>
Date:	Mon, 24 Dec 2007 00:13:01 -0700
From:	Grant Grundler <grundler@...isc-linux.org>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	linux-pci@...ey.karlin.mff.cuni.cz, Alan Cox <alan@...hat.com>,
	Greg Kroah-Hartman <greg@...ah.com>, jgarzik@...ox.com,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	wingel@...o-system.com,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	james.smart@...lex.com, linux-driver@...gic.com,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC/PATCH 2/4] pci: Remove users of pci_enable_device_bars()

Just a style nit...

On Tue, Dec 18, 2007 at 10:01:14AM +1100, Benjamin Herrenschmidt wrote:
> This patch converts users of pci_enable_device_bars() to the new
> pci_enable_device_{io,mem} interface.
> 
> The new API fits nicely, except maybe for the QLA case where a bit of
> code re-organization might be a good idea but I prefer sticking to the
> simple patch as I don't have hardware to test on.
> 
> I'll also need some feedback on the cs5520 change.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
....
>  	/* We must not grab the entire device, it has 'ISA' space in its
> -	   BARS too and we will freak out other bits of the kernel */
> -	if (pci_enable_device_bars(dev, 1<<2)) {
> +	 * BARS too and we will freak out other bits of the kernel
> +	 *
> +	 * pci_enable_device_bars() is going away. I replaced it with
> +	 * IO only enable for now but I'll need confirmation this is
> +	 * allright for that device. If not, it will need some kind of
> +	 * quirk. --BenH.
> +	 */

This comment doesn't really belong in the code. It should be part of
the commit log or email RFC.

cheers,
grant
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/