linux-kernel - Re: [PATCH - SH/Dreamcast] CD-Rom (GD-Rom) support for the SEGA Dreamcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200712240540.47501.vapier@gentoo.org>
Date:	Mon, 24 Dec 2007 05:38:35 -0500
From:	Mike Frysinger <vapier@...too.org>
To:	"Adrian McMenamin" <lkmladrian@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org,
	"Jens Axboe" <jens.axboe@...cle.com>,
	"Paul Mundt" <lethal@...ux-sh.org>
Subject: Re: [PATCH - SH/Dreamcast] CD-Rom (GD-Rom) support for the SEGA Dreamcast

On Sunday 23 December 2007, Adrian McMenamin wrote:
> On 23/12/2007, Adrian McMenamin <lkmladrian@...il.com> wrote:
> > This patch adds support for the CD-Rom (the so-called "GD-Rom") on the
> > SEGA Dreamcast.
> >
> > The GD-Rom is based on the ATA-3 standard but implements a proprietary
> > packet interface - the so-called Sega Packet Interface (SPI) and
> > supports a proprietary CD format (the "Giga Disk"). This driver
> > implements the SPI at least partially and will also read GD disks.
> >
> > There was a CD Rom driver for the 2.4 kernel series (out of mainline).
> > This, though, is new code and unlike the previous driver uses DMA and
> > not PIO to read disks.
> >
> > This is the third iteration of this patch - there remains the issue of
> > __init versus __devinit - see http://lkml.org/lkml/2007/12/23/130 but
> > I think otherwise it has dealt with most people's suggestions. The one
> > exception is that Jens suggested using sector_div, though I found that
> >  did not work.
>
> Unfortunately that patch was lined wrapped.

what e-mail client do you use ?  they usually have options for you to turn off 
line wrapping ...

> Here it is (actually, slightly fixed) again.

running it through checkpatch finds a few syntax issues ... might want to do 
that real quick and post a new one (just ignore the 80 chars warning as you 
see fit).
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (836 bytes)