linux-kernel - Re: volanoMark 24% regression in 2.6.24-rc6: why a simple patch makes it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071225082556.GA26342@elte.hu>
Date:	Tue, 25 Dec 2007 09:25:56 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	travis@....com, LKML <linux-kernel@...r.kernel.org>,
	akpm@...ux-foundation.org, suresh.b.siddha@...el.com,
	venkatesh.pallipadi@...el.com, Yinghai.Lu@....COM
Subject: Re: volanoMark 24% regression in 2.6.24-rc6: why a simple patch
	makes it

* Zhang, Yanmin <yanmin_zhang@...ux.intel.com> wrote:

> The solution is just to revert patch 
> fbdcf18df73758b2e187ab94678b30cd5f6ff9f9, because other 2 patches 
> which fixed the same issue are already in 2.6.24-rc5.

Linus, please revert fbdcf18df73758, as requested by Yanmin. It was 
noticed before (by Yinghai Lu) that this commit was not needed, but it 
looked a harmless duplication and we incorrectly thought it's only a NOP 
and wanted to fix it in v2.6.25 - but as Yanmin has analyzed it now, it 
creates a sub-optimal sched-domains hierarchy (not setting up the domain 
belonging to the core) when CONFIG_X86_HT=y.

Acked-by: Ingo Molnar <mingo@...e.hu>

nice work Yanmin!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/