linux-kernel - Re: checkpatch false ERROR: trailing statements should be on next line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071226130258.GC8346@shadowen.org>
Date:	Wed, 26 Dec 2007 13:02:58 +0000
From:	Andy Whitcroft <apw@...dowen.org>
To:	Erez Zadok <ezk@...sunysb.edu>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: checkpatch false ERROR: trailing statements should be on next line

On Tue, Dec 25, 2007 at 04:50:04PM -0500, Erez Zadok wrote:
> Using v2.6.24-rc6-125-g5356f66, code such as this:
> 
> 	if (is_file)	/* dirs can be unlinked but chdir'ed to */
> 		err = -ESTALE;
> 
> produces this false checkpatch error:
> 
> 	foo.c:947: ERROR: trailing statements should be on next line
> 
> I think comments such as the above should be allowed (plus a comment isn't a
> statement).  It's often very useful to put them right on the affected line.

Agreed.  checkpatch 0.13 already ignores these as statements.  A
positive side effect of other changes in this area.

Thanks for the report.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/