linux-kernel - Re: [PATCH 02/16] adapt lguest launcher to per-cpuness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200712271108.25173.rusty@rustcorp.com.au>
Date:	Thu, 27 Dec 2007 11:08:24 +1100
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Glauber de Oliveira Costa <gcosta@...hat.com>, lguest@...abs.org,
	glommer@...il.com, linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH 02/16] adapt lguest launcher to per-cpuness

On Thursday 27 December 2007 01:24:10 Steven Rostedt wrote:
> On Wed, 26 Dec 2007, Rusty Russell wrote:
> > On Friday 21 December 2007 00:33:42 Glauber de Oliveira Costa wrote:
> > > +		if (!vcpu_id) {
> > > +			/*
> > > +			 * Service input, then unset the BREAK to
> > > +			 * release the Waker.
> > > +			 */
> > > +			handle_input(lguest_fd);
> > > +			if (pwrite(lguest_fd, args, sizeof(args), 0) < 0)
> > > +				err(1, "Resetting break");
> > > +		}
> >
> > I hate winged comments: those two extra lines, wasted!
>
> For multiple lines, wings are a Good Thing (TM). Otherwise it looks
> sloppy.
>
>   /* Service input, then unset the BREAK to
>    * release the Waker. */
>
> extra asterisk! ok then

No, that is correct.  See all the rest of the lguest comments, or ask Dave 
Miller :)

Of course, if you can keep a comment concisely in one line, it's even better.  
But since colorizing editors are so common, the extra wings just steal 
vertical space.

> Some one buy Rusty a bigger hard-drive to store those extra lines.

More importantly, a bigger screen to hold the code :)

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/