[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20071227210315.GB17782@colo.lackof.org>
Date: Thu, 27 Dec 2007 14:03:15 -0700
From: Grant Grundler <grundler@...isc-linux.org>
To: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc: Grant Grundler <grundler@...isc-linux.org>,
linux-pci@...ey.karlin.mff.cuni.cz, Alan Cox <alan@...hat.com>,
Greg Kroah-Hartman <greg@...ah.com>, jgarzik@...ox.com,
Ivan Kokshaysky <ink@...assic.park.msu.ru>,
wingel@...o-system.com,
Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
james.smart@...lex.com, linux-driver@...gic.com,
linux-kernel@...r.kernel.org
Subject: Re: [RFC/PATCH 4/4] [POWERPC] pci: Disable IO/Mem on a device when
resources can't be allocated
On Wed, Dec 26, 2007 at 08:26:27AM +1100, Benjamin Herrenschmidt wrote:
>
> > This is exactly what's supposed to be happening, but the code is buggy
> > and nobody noticed :-) (I'm mixing up IORESOURCE_* flags and
> > PCI_COMMAND_* flags). Thanks for reviewing !
>
> Note that this patch isn't in the series Greg queued up anyway. The
> powerpc specific bits will be going in via Paulus an I already asked him
> to drop that specific one until I send a fixed version.
Ah ok....but I was mostly worried about the use of PPC bits as an example.
Anyway, in general it looks like the right direction to me too.
cheers,
grant
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists