linux-kernel - Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071227212121.GD11638@parisc-linux.org>
Date:	Thu, 27 Dec 2007 14:21:21 -0700
From:	Matthew Wilcox <matthew@....cx>
To:	Loic Prylli <loic@...i.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Robert Hancock <hancockr@...w.ca>,
	Jeff Garzik <jeff@...zik.org>,
	Arjan van de Ven <arjan@...radead.org>,
	linux-kernel@...r.kernel.org, gregkh@...e.de,
	linux-pci <linux-pci@...ey.karlin.mff.cuni.cz>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Martin Mares <mj@....cz>
Subject: Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

On Thu, Dec 27, 2007 at 04:10:33PM -0500, Loic Prylli wrote:
> The root pcie port implementation is obviously buggy. But did we confirm
> whether that hardware bug might be partly related to
> "configuration-retry-status" pcie-root handling as introduced/described in:
> 
> http://marc.info/?l=linux-kernel&m=110541914926842&w=2
> 
> Does the 0001 vendor-id still shows up if pci_enable_crs() has never
> been called?
> 
> Does anybody knows what was the original rational to call
> pci_enable_crs() by default?

If you don't call pci_enable_crs(), no device can return the retry
status, so it would be pointless having this code in the kernel at all.
If it turns out some devices are buggy, then obviously we shouldn't
enable it for them.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/