[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200712270401.35983.vda.linux@googlemail.com>
Date: Thu, 27 Dec 2007 04:01:35 +0000
From: Denys Vlasenko <vda.linux@...glemail.com>
To: Patrick McHardy <kaber@...sh.net>
Cc: Harald Welte <laforge@...monks.org>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Netfilter Development Mailinglist
<netfilter-devel@...r.kernel.org>
Subject: Re: [PATCH] net/ipv4/netfilter/ip_tables.c: remove some inlines
On Monday 17 December 2007 14:47, Patrick McHardy wrote:
> Please CC netfilter-devel on netfilter patches.
>
> Denys Vlasenko wrote:
> > Hi Patrick, Harald,
> >
> > I was working on unrelated problem and noticed that ip_tables.c
> > seem to abuse inline. I prepared a patch which removes inlines
> > except those which are used by packet matching code
> > (and thus are really performance-critical).
> > I added comments explaining that remaining inlines are
> > performance critical.
> >
> > Result as reported by size:
> >
> > text data bss dec hex filename
> > - 6451 380 88 6919 1b07 ip_tables.o
> > + 6339 348 72 6759 1a67 ip_tables.o
> >
> > Please take this patch into netfilter queue.
>
> This clashes with my pending patches, which I'll push upstream
> today. I also spent some time resyncing ip_tables and ip6_tables
> so a diff of both (with some sed'ing) shows only the actual
> differences, so please update ip6_tables as well.
I would be happy to rediff the patch.
Which tree should I sync against in order to not collide
with your changes?
--
vda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists