linux-kernel - Re: [PATCH] SH/Dreamcast - add support for GD-Rom device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200712271949.02942.vapier@gentoo.org>
Date:	Thu, 27 Dec 2007 19:49:01 -0500
From:	Mike Frysinger <vapier@...too.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Adrian McMenamin <adrian@...golddream.dyndns.info>,
	Paul Mundt <lethal@...ux-sh.org>,
	Jens Axboe <jens.axboe@...cle.com>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-sh <linux-sh@...r.kernel.org>
Subject: Re: [PATCH] SH/Dreamcast - add support for GD-Rom device

On Thursday 27 December 2007, Joe Perches wrote:
> On Thu, 2007-12-27 at 16:52 +0000, Adrian McMenamin wrote:
> > This patch adds support for the CD-Rom drive on the SEGA Dreamcast.
>
> Because it was already so close, might as well make it checkpatch clean.

for the 80 col limit, that's up to the author.  if Adrian is happy with it as 
is, that's fine.

> I also added a function gdrom_is_busy() to make a couple of tests
> fit on a single line and perhaps easier to read.

i'd tend to agree it does make it easier to read, however you didnt make it 
inline which means gcc may not inline it which means there's pointless 
overhead of doing a function call.

otherwise, arbitrary breaking on 80 cols actually makes the code harder to 
read for no gain.
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (836 bytes)