linux-kernel - Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1198819646.7209.23.camel@pasglop>
Date:	Fri, 28 Dec 2007 16:27:26 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Loic Prylli <loic@...i.com>, Robert Hancock <hancockr@...w.ca>,
	Jeff Garzik <jeff@...zik.org>,
	Arjan van de Ven <arjan@...radead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	gregkh@...e.de, linux-pci <linux-pci@...ey.karlin.mff.cuni.cz>,
	Martin Mares <mj@....cz>, Matthew Wilcox <matthew@....cx>,
	Kai Ruhnau <kai@...getaschen.dyndns.org>
Subject: Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver
	opt-in


On Thu, 2007-12-27 at 13:37 -0800, Linus Torvalds wrote:
> 
> > Does anybody knows what was the original rational to call
> > pci_enable_crs() by default?
> 
> .. another good question. I don't think anybody expected it to be
> broken, 
> but if this turns out to be the thing that triggers it, I think we
> should 
> disable CRS by default.

Some sane archs need CRS and do a lot of HW.. However, just testing for
vendor ID being 0x0001 instead of testing all bits might be a useable
workaround.

> The code doesn't actually do what CRS is supposed to help with (ie go
> on 
> to probe another device and then come back to the slow one later), so 
> right now it's pretty much useless *anyway*. 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/