linux-kernel - Re: fib6_del_route has redundant code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4774907D.5070806@cn.fujitsu.com>
Date:	Fri, 28 Dec 2007 13:58:21 +0800
From:	Gui Jianfeng <guijianfeng@...fujitsu.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: fib6_del_route has redundant code

>> I think the following code in fib6_del_route in the latest kernel is useless.
>> 1125         if (fn->leaf == NULL && fn->fn_flags&RTN_TL_ROOT)
>> 1126                 fn->leaf = &ip6_null_entry;
>>
>> ip6_null_entry will never be unlinked from fn->leaf now, that is,
>> fn->leaf == NULL will never meet.
> 
> I think you are right, but if it is true the next block of
> code is dead too:
> 
> 	/* If it was last route, expunge its radix tree node */
> 	if (fn->leaf == NULL) {
> 		fn->fn_flags &= ~RTN_RTINFO;
> 		rt6_stats.fib_route_nodes--;
> 		fn = fib6_repair_tree(fn);
> 	}
> 
Dave,

I think this block of code can't be removed, because just the root(default route)
fn->leaf always has ip6_null_entry on it. The normal fn->leaf becomes NULL when last
route has been deleted, the radix tree should be expunged.

> But I am not completely convinced that all of these lines
> of code can be removed :-)
> 
> 

-- 


Regards
Gui Jianfeng
--------------------------------------------------
Gui Jianfeng
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
8/F., Civil Defense Building, No.189 Guangzhou Road,
Nanjing, 210029, China
TEL: +86+25-86630566-838
COINS: 79955-838
FAX: +86+25-83317685
MAIL:guijianfeng@...fujitsu.com
--------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/