linux-kernel - Re: [PATCH 03/12] firewire : Use mutex instead of semaphore in driver core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <477632AC.2000502@s5r6.in-berlin.de>
Date:	Sat, 29 Dec 2007 12:42:36 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Dave Young <hidave.darkstar@...il.com>
CC:	krh@...hat.com, linux-kernel@...r.kernel.org,
	linux1394-devel@...ts.sourceforge.net
Subject: Re: [PATCH 03/12] firewire : Use mutex instead of semaphore in driver
 core

Dave Young wrote:
> --- linux/drivers/firewire/fw-device.c	2007-12-28 10:02:38.000000000 +0800
> +++ linux.new/drivers/firewire/fw-device.c	2007-12-28 10:05:00.000000000 +0800
> @@ -26,7 +26,7 @@
>  #include <linux/delay.h>
>  #include <linux/idr.h>
>  #include <linux/rwsem.h>
> -#include <asm/semaphore.h>
> +#include <linux/mutex.h>
>  #include <linux/ctype.h>
>  #include "fw-transaction.h"
>  #include "fw-topology.h"
> @@ -731,9 +731,9 @@ static int update_unit(struct device *de
>  	struct fw_driver *driver = (struct fw_driver *)dev->driver;
>  
>  	if (is_fw_unit(dev) && driver != NULL && driver->update != NULL) {
> -		down(&dev->sem);
> +		mutex_lock(&dev->mutex);
>  		driver->update(unit);
> -		up(&dev->sem);
> +		mutex_unlock(&dev->mutex);
>  	}
>  
>  	return 0;

ACK to this part of the series.
-- 
Stefan Richter
-=====-=-=== ==-- ===-=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/