linux-kernel - Re: [PATCH 11/12] spi : Use mutex instead of semaphore in driver core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200712281737.13145.david-b@pacbell.net>
Date:	Fri, 28 Dec 2007 17:37:12 -0800
From:	David Brownell <david-b@...bell.net>
To:	Dave Young <hidave.darkstar@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	spi-devel-general@...ts.sourceforge.net
Subject: Re: [PATCH 11/12] spi : Use mutex instead of semaphore in driver core

On Friday 28 December 2007, Dave Young wrote:
> Signed-off-by: Dave Young <hidave.darkstar@...il.com> 

ACK ... if the driver core is changing, this is obvious.
 
> ---
> drivers/spi/spi.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c
> --- linux/drivers/spi/spi.c	2007-12-28 10:47:38.000000000 +0800
> +++ linux.new/drivers/spi/spi.c	2007-12-28 10:48:22.000000000 +0800
> @@ -494,7 +494,7 @@ struct spi_master *spi_busnum_to_master(
>  	struct spi_master	*master = NULL;
>  	struct spi_master	*m;
>  
> -	down(&spi_master_class.sem);
> +	mutex_lock(&spi_master_class.mutex);
>  	list_for_each_entry(dev, &spi_master_class.children, node) {
>  		m = container_of(dev, struct spi_master, dev);
>  		if (m->bus_num == bus_num) {
> @@ -502,7 +502,7 @@ struct spi_master *spi_busnum_to_master(
>  			break;
>  		}
>  	}
> -	up(&spi_master_class.sem);
> +	mutex_unlock(&spi_master_class.mutex);
>  	return master;
>  }
>  EXPORT_SYMBOL_GPL(spi_busnum_to_master);
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/