linux-kernel - Re: [PATCH 1/1] mxser, remove it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071229022329.39f6162a@the-village.bc.nu>
Date:	Sat, 29 Dec 2007 02:23:29 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jan Engelhardt <jengelh@...putergmbh.de>
Cc:	Jiri Slaby <jirislaby@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Adrian Bunk <bunk@...nel.org>,
	Michael Tokarev <mjt@....msk.ru>
Subject: Re: [PATCH 1/1] mxser, remove it

> > 
> >+static int mxvar_baud_table[] = {
> >+	0, 50, 75, 110, 134, 150, 200, 300, 600, 1200, 1800, 2400,
> >+	4800, 9600, 19200, 38400, 57600, 115200, 230400, 460800, 921600
> >+};
> >+static unsigned int mxvar_baud_table1[] = {
> >+	0, B50, B75, B110, B134, B150, B200, B300, B600, B1200, B1800, B2400,
> >+	B4800, B9600, B19200, B38400, B57600, B115200, B230400, B460800, B921600
> >+};
> 
> Constify both, if possible?

These are not portable - baud rate tables vary for some platforms. No
driver should be touching Bxxx coding itself any more. Use the tty_
functions to decode and encode baud rates.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/