linux-kernel - Re: [PATCH 06/12] pci : Use mutex instead of semaphore in driver core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071229025506.GL11638@parisc-linux.org>
Date:	Fri, 28 Dec 2007 19:55:07 -0700
From:	Matthew Wilcox <matthew@....cx>
To:	Dave Young <hidave.darkstar@...il.com>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	linux-pci@...ey.karlin.mff.cuni.cz
Subject: Re: [PATCH 06/12] pci : Use mutex instead of semaphore in driver core

On Sat, Dec 29, 2007 at 09:10:57AM +0800, Dave Young wrote:
> @@ -207,9 +207,9 @@ void pci_walk_bus(struct pci_bus *top, v
>  			next = dev->bus_list.next;
>  
>  		/* Run device routines with the device locked */
> -		down(&dev->dev.sem);
> +		mutex_lock(&dev->dev.mutex);
>  		cb(dev, userdata);
> -		up(&dev->dev.sem);
> +		mutex_unlock(&dev->dev.mutex);
>  	}
>  	up_read(&pci_bus_sem);
>  }

Patches should be self-contained for ease of bisecting.  I can't tell
whether this patch is correct or not because you haven't included all
the other places that need to change at the same time as this.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/