linux-kernel - Re: [PATCH] x86: Introduce REX prefix helper for kprobes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071230131910.GE16946@elte.hu>
Date:	Sun, 30 Dec 2007 14:19:10 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Masami Hiramatsu <mhiramat@...hat.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Harvey Harrison <harvey.harrison@...il.com>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Jim Keniston <jkenisto@...ibm.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] x86: Introduce REX prefix helper for kprobes


* Masami Hiramatsu <mhiramat@...hat.com> wrote:

> > Why is a macro better than an inline, and why the odd mIXed case?
> 
> I thought we can use macro because it just check a bit mask. And if we 
> use this as a macro, it will be defined in #ifdef block at the top of 
> kprobes.c. It is simple in this case. I know the inline is better than 
> the macro, it can check the type of arguments. If you would like to 
> use inline, how about this?

yes, we prefer inlines for just about everything. We have reoccuring 
regressions due to macro side-effects, lack of type and argument 
checking - and the simplest maintenance policy is to just never 
introduce new macros. Macros also played an active role in creating our 
current include file dependencies spaghetti. So unless there are very, 
very strong reasons in favor of adding a macro, please always use 
inlines.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/