linux-kernel - Re: [patch?] s2ram + P4 + tsc = annoyance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071230140456.GJ16946@elte.hu>
Date:	Sun, 30 Dec 2007 15:04:56 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Mike Galbraith <efault@....de>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [patch?] s2ram + P4 + tsc = annoyance


* Mike Galbraith <efault@....de> wrote:

> Or, reset to pristine prior to testing, though that's more lines to 
> accomplish the same thing.  Either way, or some other way...
> 
> If check_tsc_warp() is called after initial boot, and the TSC has in 
> the meantime been set (BIOS, user, silicon, elves) to a value lower 
> than the last stored/stale value, we blame the TSC.  Reset to pristine 
> condition after every test.

ok, i prefer this fix a bit more. (we dont want to set last_tsc outside 
of the sync_lock - which your initial patch does)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/