linux-kernel - Re: [PATCH] x86_64: clear IO_APIC before enabing apic error vector. v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 30 Dec 2007 15:51:15 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <Yinghai.Lu@....COM>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Andi Kleen <ak@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86_64: clear IO_APIC before enabing apic error
	vector. v2


* Yinghai Lu <Yinghai.Lu@....COM> wrote:

> please check if you can replace the one in the x86-mm
> 
> http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=commitdiff;h=ffcbdc220a1520d006a837f33589c7c19ffbeb76
> 
> the updated one avoid one link warning.

please send delta patches instead - so that we can review the changes.

> this is the updated verison that take enable_IO_APIC as extra call for 
> setup_local_APIC to avoid linking warning.

hm, what link warning did you get? Perhaps the following __cpuinit:

> -void __cpuinit setup_local_APIC (void)

does not mix well with an __init call:

> +void __init enable_IO_APIC(void)

and you hack it around by using a function pointer. Nasty and still 
buggy. The proper solution would be to mark enable_IO_APIC as __cpuinit 
too (or something like that).

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/