linux-kernel - Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0712301651000.8187@ask.diku.dk>
Date:	Sun, 30 Dec 2007 16:51:38 +0100 (CET)
From:	Julia Lawall <julia@...u.dk>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq,
 etc.

On Sun, 30 Dec 2007, Ingo Molnar wrote:

> 
> * Julia Lawall <julia@...u.dk> wrote:
> 
> > > your x86 patches (#7, #8 and #9) do not include any *_eq() 
> > > comparisons and they all seem to be correct. So picked those three 
> > > up into x86.git - let me know if there's any breakage in them that i 
> > > missed.
> > 
> > Only #7 is ok.  The other two have #include <jiffies.h> in the wrong 
> > place.  I will send new versions of #8 and #9 shortly.
> 
> hm, #include file order in a .c file should normally not matter - why 
> are they in the wrong place?

Because they are under #ifdefs, but the code that uses the time functions 
is not under the same #ifdef.

julia

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/