linux-kernel - Re: [RFC][PATCH] byteorder: introduce le32_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071231194146.GT13821@ca-server1.us.oracle.com>
Date:	Mon, 31 Dec 2007 11:41:46 -0800
From:	Mark Fasheh <mark.fasheh@...cle.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Marcin Slusarz <marcin.slusarz@...il.com>,
	ocfs2-devel@....oracle.com, LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors <kernel-janitors@...r.kernel.org>
Subject: Re: [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to
	core

On Mon, Dec 31, 2007 at 09:17:32AM +0000, Christoph Hellwig wrote:
> > be32_add is shorter than be32_add_cpu but I think it's not clear
> > whether second parameter is in native byte order or not.
> 
> Then again adding foreing endian values doesn't make much sense.
> 
> If you insist on your naming please make sure to convert ocfs and xfs
> to your naming.

Personally, I'd rather stick with the (IMHO) more descriptive name - btw,
the ones he picked don't require any extra conversion in Ocfs2.
	--Mark

--
Mark Fasheh
Principal Software Developer, Oracle
mark.fasheh@...cle.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/