linux-kernel - Re: [RFC][PATCH] byteorder: introduce le32_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071231091732.GA29043@infradead.org>
Date:	Mon, 31 Dec 2007 09:17:32 +0000
From:	Christoph Hellwig <hch@...radead.org>
To:	Marcin Slusarz <marcin.slusarz@...il.com>
Cc:	Christoph Hellwig <hch@...radead.org>, ocfs2-devel@....oracle.com,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors <kernel-janitors@...r.kernel.org>
Subject: Re: [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to
	core

On Sun, Dec 30, 2007 at 10:49:34PM +0100, Marcin Slusarz wrote:
> I found it in XFS only. Did I miss something?

These helpers come from ocfs2 which has both be and le variants.

> be32_add is shorter than be32_add_cpu but I think it's not clear
> whether second parameter is in native byte order or not.

Then again adding foreing endian values doesn't make much sense.

If you insist on your naming please make sure to convert ocfs and xfs
to your naming.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/