linux-kernel - Re: [x86] get rid of checkpatch.pl complains on apm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 1 Jan 2008 16:00:54 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [x86] get rid of checkpatch.pl complains on apm_32.c


* Cyrill Gorcunov <gorcunov@...il.com> wrote:

> This patch eliminates most of code-style errors discovered by 
> checkpatch.pl on arch/x86/kernel/apm_32.c

looks good in principle, but the patch is not a NOP:

    text    data     bss     dec     hex filename
   12142    1837      84   14063    36ef apm_32.o.before
   12141    1837      84   14062    36ee apm_32.o.after
 md5:
 2676b881ad55e387da4a995e8b9ee372  apm_32.o.before.asm
 7fcce83dca90ded66cc43f9b4d4ca2d2  apm_32.o.after.asm

cleanup patches should not change the resulting object code. The change 
is due to this hunk:

@@ -1918,8 +1940,9 @@ static int __init apm_is_horked_d850md(c
 {
 	if (apm_info.disabled == 0) {
 		apm_info.disabled = 1;
-		printk(KERN_INFO "%s machine detected. Disabling APM.\n", d->ident);
-		printk(KERN_INFO "This bug is fixed in bios P15 which is available for \n");
+		printk(KERN_INFO "%s machine detected. "
+		       "Disabling APM.\n", d->ident);
+		printk(KERN_INFO "This bug is fixed in bios P15 which is available for\n");
 		printk(KERN_INFO "download from support.intel.com \n");
 	}
 	return 0;

the "for \n" has been changed to "for\n". Which is an OK cleanup, but 
please do such material changes in separate patches in the future. (we 
can accept and review cleanup patches that are NOPs much easier and 
faster)

so i removed that string change and applied your patch to x86.git, which 
is now a nice NOP:

    text    data     bss     dec     hex filename
   12142    1837      84   14063    36ef apm_32.o.before
   12142    1837      84   14063    36ef apm_32.o.after

 md5:

   2676b881ad55e387da4a995e8b9ee372  apm_32.o.before.asm
   2676b881ad55e387da4a995e8b9ee372  apm_32.o.after.asm

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/