lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 1 Jan 2008 15:09:08 +0900
From:	"Joonwoo Park" <joonwpark81@...il.com>
To:	"jacliburn@...lsouth.net" <jacliburn@...lsouth.net>
Cc:	jeff@...zik.org, csnook@...hat.com, linux-kernel@...r.kernel.org,
	atl1-devel@...ts.sourceforge.net
Subject: Re: [PATCH 25/26] atl1: add NAPI support

2008/1/1, jacliburn@...lsouth.net <jacliburn@...lsouth.net>:
> From: Jay Cliburn <jacliburn@...lsouth.net>
>
> Add support for NAPI, styled after the e1000 NAPI implementation.  That we
> follow the e1000 for NAPI shouldn't come as much of a surprise, since the
> entire atl1 driver is based heavily upon it.
>
> Signed-off-by: Jay Cliburn <jacliburn@...lsouth.net>
> ---
>  drivers/net/Kconfig     |   14 ++++
>  drivers/net/atlx/atl1.c |  151 +++++++++++++++++++++++++++++++++++++++++++++--
>  drivers/net/atlx/atl1.h |   20 ++++++
>  drivers/net/atlx/atlx.h |    7 ++-
>  4 files changed, 186 insertions(+), 6 deletions(-)
>
> +       if ((!tx_cleaned && (work_done == 0)) ||
> +               !netif_running(poll_dev)) {
> +quit_polling:
> +               netif_rx_complete(poll_dev, napi);
> +
> +               if (!test_bit(__ATL1_DOWN, &adapter->flags))
> +                       atlx_irq_enable(adapter);
> +       }

Hi Jay,
if buget == work_done is true, you should not call netif_rx_complete.
Searching recent netdev mailbox would be help.

Thanks.
Joonwoo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists