linux-kernel - Re: [PATCH] Fix errors detected by checkpatch.pl on nmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a8748490801011802q7b6bd8e7w38813eb2e5502e50@mail.gmail.com>
Date:	Wed, 2 Jan 2008 03:02:09 +0100
From:	"Jesper Juhl" <jesper.juhl@...il.com>
To:	"Carlos R. Mafra" <crmafra@...il.com>
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix errors detected by checkpatch.pl on nmi_int.c

On 02/01/2008, Carlos R. Mafra <crmafra@...il.com> wrote:
> This patch fixes most errors detected by checkpatch.pl.
>
>                                      errors   lines of code   errors/KLOC
> arch/x86/oprofile/nmi_int.c (after)       1             461           2.1
> arch/x86/oprofile/nmi_int.c (before)     60             477         125.7
>
> No code changed.
>
> size:
>    text    data     bss     dec     hex filename
>    2675     264     472    3411     d53 nmi_int.o.after
>    2675     264     472    3411     d53 nmi_int.o.before
>
> md5sum:
>   847aea0cc68fe1a2b5e7019439f3b4dd  nmi_int.o.after
>   847aea0cc68fe1a2b5e7019439f3b4dd  nmi_int.o.before
>
> Signed-off-by: Carlos R. Mafra <crmafra@...il.com>
>

Looks good to me (except that an inline patch instead of an attached
one would have been nice ;-)

Kills some trailing whitespace, does some CodingStyle cleanups, is
nicely confined to one file, doesn't (as far as I can tell) change the
way the code works, makes checkpatch less noisy. All good.

Feel free to add
  Reviewed-by: Jesper Juhl <jesper.juhl@...il.com>
if you like.

-- 
Jesper Juhl <jesper.juhl@...il.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/