lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Jan 2008 21:23:15 +0100 From: Ingo Molnar <mingo@...e.hu> To: Abhishek Sagar <sagar.abhishek@...il.com> Cc: Masami Hiramatsu <mhiramat@...hat.com>, Harvey Harrison <harvey.harrison@...il.com>, "H. Peter Anvin" <hpa@...or.com>, LKML <linux-kernel@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, qbarnes@...il.com, ananth@...ibm.com, jkenisto@...ibm.com Subject: Re: [PATCH] x86: kprobes change kprobe_handler flow * Abhishek Sagar <sagar.abhishek@...il.com> wrote: > > > + default: > > > + /* impossible cases */ > > > + BUG(); > > > > I think no need to check that here. > > It may not get hit at runtime but is quite informative. sidenote: please use WARN_ON(1) instead. In the case of the impossible triggering somehow (the Linux kernel is notorious for that ;-), we'd have a nice WARN_ON(1) in the dmesg, instead of a crashed box. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists