linux-kernel - Re: [PATCH] checkpatch.pl: recognize the #elif preprocessor directive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080102094956.GB23164@shadowen.org>
Date:	Wed, 2 Jan 2008 09:49:56 +0000
From:	Andy Whitcroft <apw@...dowen.org>
To:	Benny Halevy <bhalevy@...asas.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Joel Schopp <jschopp@...tin.ibm.com>
Subject: Re: [PATCH] checkpatch.pl: recognize the #elif preprocessor directive

On Tue, Jan 01, 2008 at 12:12:22PM +0200, Benny Halevy wrote:
> checkpatch.pl does not recognize #elif as a preprocessor directive
> causing it to print bogus errors for, e.g.:
> ERROR: need consistent spacing around '&' (ctx:WxV)
> when the operator is not recognized as unary in this context.
> 
> for example:
> 
> void foo(void)
> {
> 	int x, y, z;
> 	void *p[1] = {
> #if defined(X)
> 		&x
> #elif defined(Y)
> 		&y
> #else
> 		&z
> #endif
> 	};
> }
> 
> Signed-off-by: Benny Halevy <bhalevy@...asas.com>

Yes, thanks; good catch.  Commited this and added tests for it.
Will be in 0.13 which is imminent.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/