linux-kernel - Re: [PATCH] x86: Use is_kprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080103093837.GA18355@elte.hu>
Date:	Thu, 3 Jan 2008 10:38:37 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	qbarnes <qbarnes@...il.com>, "H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] x86: Use is_kprobe_fault to better match usage


* Harvey Harrison <harvey.harrison@...il.com> wrote:

> Currently the notify_page_fault helper is used to test it the page 
> fault was caused by a kprobe causing an early return from 
> do_page_fault.
> 
> Change the name of the helper to is_kprobe_fault to match the usage 
> and remove the preempt_disable/enable pair around kprobe_running() 
> with an explicit test for preemption.  The idea for this comes from a 
> patch by Quentin Barnes to kprobes.c
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>

hm, this doesnt apply:

 Hunk #3 FAILED at 426.
 Hunk #4 succeeded at 413 (offset -22 lines).
 1 out of 4 hunks FAILED -- rejects in file arch/x86/mm/fault_32.c
 patching file arch/x86/mm/fault_64.c
 Hunk #3 FAILED at 476.
 Hunk #4 succeeded at 475 (offset -10 lines).
 1 out of 4 hunks FAILED -- rejects in file arch/x86/mm/fault_64.c

could you double-check x86.git#mm, perhaps we are out of sync with a 
patch somewhere?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/