linux-kernel - Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080103145028.GH8046@cvg>
Date:	Thu, 3 Jan 2008 17:50:28 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	Jörn Engel <joern@...fs.org>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

[David Woodhouse - Thu, Jan 03, 2008 at 02:37:24PM +0000]
| 
| On Thu, 2008-01-03 at 15:37 +0100, Ingo Molnar wrote:
| > * David Woodhouse <dwmw2@...radead.org> wrote:
| > 
| > > On Thu, 2008-01-03 at 15:05 +0100, Ingo Molnar wrote:
| > > > not to make a big issue out of this, but when was the last time you 
| > > > tried to grep this way:
| > > > 
| > > >   grep -E "audit_rate_limit=[0-9]+ audit_backlog" */*.c
| > > 
| > > Not precisely that, but I've certainly had greps fail because people 
| > > have split up strings to meet the stupid 80-character "limit".
| > 
| > yes - but if you read my whole reply you'll see that i qualified it:
| > 
| > >> That's pretty much the only grep pattern that would break. People 
| > >> usually grep on the constant portion of the string, so breaking up a 
| > >>                                                       ^^^^^^^^^^^^^
| > >> line along a variable boundary is perfectly okay.
| 
| Yes, you did. But you failed to provide any good reason for actually
| changing it, either. Leave it as it was.
| 
| -- 
| dwmw2
| 

so what i would do now? i could post updated patch *without* that
splitted line, should I?

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/