linux-kernel - Re: struct should not be named same way as function in sony-laptop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080103170930.GA1728@elf.ucw.cz>
Date:	Thu, 3 Jan 2008 18:09:30 +0100
From:	Pavel Machek <pavel@....cz>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	malattia@...ux.it, kernel list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>, trivial@...nel.org
Subject: Re: struct should not be named same way as function in sony-laptop

On Thu 2008-01-03 11:15:43, Al Viro wrote:
> On Thu, Jan 03, 2008 at 12:01:54PM +0100, Pavel Machek wrote:
> > Naming struct and function by same name is evil. Rename the struct.
> 
> Um... why?  It's not even particulary bad style per se...  Occurs less
> frequently than things like
> 	struct foo *foo;
> but nothing inherently terrible and not likely to cause any kind of
> confusion.

Well, it confused me a lot in this particular case...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/