linux-kernel - Re: [PATCH 1/3] Unionfs: use printk KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200801031836.m03Ia6Cb024361@agora.fsl.cs.sunysb.edu>
Date:	Thu, 3 Jan 2008 13:36:06 -0500
From:	Erez Zadok <ezk@...sunysb.edu>
To:	Joe Perches <joe@...ches.com>
Cc:	Erez Zadok <ezk@...sunysb.edu>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	viro@....linux.org.uk, hch@...radead.org
Subject: Re: [PATCH 1/3] Unionfs: use printk KERN_CONT for debugging messages 

In message <1199341581.6615.39.camel@...alhost>, Joe Perches writes:
> On Thu, 2008-01-03 at 00:57 -0500, Erez Zadok wrote:

> I think printks should be single statements and
> KERN_CONT should be used as sparingly as possible.
[...]

KERN_CONT is documented as not being SMP safe, but I figured it was harmless
for just some debugging message.  Still, I like your way better.  Thanks
Joe.

> Perhaps:
> 		pr_debug("IT(%lu:%d): %s:%s:%d "
> 			 "um=%lu/%lu lm=%lu/%lu "
> 			 "uc=%lu/%lu lc=%lu/%lu\n",
> 			 inode->i_ino, bindex, file, fnx, line,
> 			 inode->i_mtime.tv_sec, inode->i_mtime.tv_nsec,
> 			 lower_inode->i_mtime.tv_sec,
> 			 lower_inode->i_mtime.tv_nsec
> 			 inode->i_ctime.tv_sec, inode->i_ctime.tv_nsec,
> 			 lower_inode->i_ctime.tv_sec,
> 			 lower_inode->i_ctime.tv_nsec);
[...]

Erez.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/