linux-kernel - Re: [patch 1/3] move WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <477D4E50.4020004@linux.intel.com>
Date:	Thu, 03 Jan 2008 22:06:24 +0100
From:	Arjan van de Ven <arjan@...ux.intel.com>
To:	Matt Mackall <mpm@...enic.com>
CC:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [patch 1/3] move WARN_ON() out of line

Matt Mackall wrote:
> 
> I hate the do_foo naming scheme (how about __warn_on?), but otherwise:
> 
> Acked-by: Matt Mackall <mpm@...enic.com>

after I moved it around based on Olof's work, I've now ended up with

warn_on_slowpath()

> 
>> +		printk(KERN_WARNING "WARNING: at %s:%d %s()\n",
>> +			__FILE__, __LINE__, __FUNCTION__);
>> +		dump_stack();
> 
> While we're here, I'll mention that dump_stack probably ought to take a
> severity level argument.

125 files changed, 202 insertions(+), 199 deletions(-)
just to get the api change done.
I can hear akpm cringe from here...

> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/